Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Posthog no-capture #5693

Merged
merged 11 commits into from
Mar 23, 2023
Merged

fix: Update Posthog no-capture #5693

merged 11 commits into from
Mar 23, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 15, 2023
@mutdmour mutdmour marked this pull request as ready for review March 21, 2023 14:27
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (33d9784) 14.31% compared to head (c03aa7d) 14.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5693      +/-   ##
==========================================
+ Coverage   14.31%   14.41%   +0.10%     
==========================================
  Files        2466     2469       +3     
  Lines      112895   113048     +153     
  Branches    17555    17595      +40     
==========================================
+ Hits        16160    16295     +135     
- Misses      96235    96236       +1     
- Partials      500      517      +17     
Impacted Files Coverage Δ
packages/cli/src/config/index.ts 36.11% <100.00%> (ø)

... and 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OlegIvaniv OlegIvaniv self-assigned this Mar 22, 2023
@mutdmour mutdmour merged commit a732374 into master Mar 23, 2023
@mutdmour mutdmour deleted the ado-227 branch March 23, 2023 10:20
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 23, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
…nd-foundations-sheets-node-api-endpoint

* feature/resource-mapping-component:
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ci: Upgrade sanitize-html from 2.9.0 to 2.10.0 (#5744)
  fix(core): Remove circular refs from Code and push msg (#5741)
  fix(HTTP Request Node): Add streaming to binary response  (#5701)
  fix(core): Force-upgrade `http-cache-semantics` to address CVE-2022-25881 (#5733)
  fix(core): Force-upgrade `decode-uri-component` to address CVE-2022-38900 (#5734)
MiloradFilipovic added a commit that referenced this pull request Mar 24, 2023
* master: (80 commits)
  feat: Execution custom data saving and filtering (#5496)
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ...
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with n8n@0.222.0

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* feat: add no-capture class for schema view

* fix: add ee nocapture

* fix: update no capture

* fix: update ndv capturing

* feat: remove no capture from empty resources list

* lint: fix

* test: update tests

* test: add json view tests

* fix: update more class to cover

* lint: fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants