feat(editor): Fix ResourceLocator dropdown style #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
1 flaky tests on run #238 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data transformation expressions > $json + native array access |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5714 +/- ##
==========================================
- Coverage 14.32% 14.32% -0.01%
==========================================
Files 2465 2465
Lines 112916 112916
Branches 17556 17562 +6
==========================================
- Hits 16176 16173 -3
- Misses 96238 96241 +3
Partials 502 502 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
OlegIvaniv
commented
Mar 20, 2023
| }, | ||
| methods: { | ||
| isRemoteParameterOption(option: INodePropertyOptions) { | ||
| return this.remoteParameterOptions.map((o) => o.name).includes(option.name); | ||
| return this.remoteParameterOptionsKeys.includes(option.name); |
There was a problem hiding this comment.
It's more efficient to have remoteParameterOptions key as a computed and check if it includes option.name rather than mapping it every time for each option which leads in app hanging for several seconds if there are many options, for example, in CoinGeco node.
mutdmour
approved these changes
Mar 22, 2023
| }, | ||
| methods: { | ||
| isRemoteParameterOption(option: INodePropertyOptions) { | ||
| return this.remoteParameterOptions.map((o) => o.name).includes(option.name); | ||
| return this.remoteParameterOptionsKeys.includes(option.name); |
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 23, 2023
…nd-foundations-sheets-node-api-endpoint * feature/resource-mapping-component: fix(editor): Use credentials when fetching node and credential types (#5760) fix: Update Posthog no-capture (#5693) fix(core): Return SAML service provider urls with config (#5759) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) feat(editor): Fix ResourceLocator dropdown style (#5714) feat(Filter Node): New node fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742) feat(core): Make OAuth2 error handling consistent with success handling (#5555) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) ci: Upgrade sanitize-html from 2.9.0 to 2.10.0 (#5744) fix(core): Remove circular refs from Code and push msg (#5741) fix(HTTP Request Node): Add streaming to binary response (#5701) fix(core): Force-upgrade `http-cache-semantics` to address CVE-2022-25881 (#5733) fix(core): Force-upgrade `decode-uri-component` to address CVE-2022-38900 (#5734)
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 24, 2023
* master: (80 commits) feat: Execution custom data saving and filtering (#5496) ci: Fix saml.api.test.ts (no-changelog) (#5764) docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763) 🚀 Release 0.221.0 (#5726) fix(core): Persist CurrentAuthenticationMethod setting change (#5762) feat(core): Limit user invites when SAML is enabled (#5761) fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) fix(editor): Use credentials when fetching node and credential types (#5760) fix: Update Posthog no-capture (#5693) fix(core): Return SAML service provider urls with config (#5759) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) feat(editor): Fix ResourceLocator dropdown style (#5714) feat(Filter Node): New node fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742) feat(core): Make OAuth2 error handling consistent with success handling (#5555) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) ...
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
* fix(editor): Fix ResourceLocator dropdown style * Fix other popper classes * Fix app hanging if loading many remote parameter options * Make ResourceLocatorDropdown flex * Override scrollbar styles * Hide resource locator on outside click not input blur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the ResourceLocator popover override styles wouldn't apply, resulting in a slightly broken UI of this component. What's peculiar, is that this is only happening in production build, in dev it looks as it should. After some investigation, I found it's an issue with Vite (vitejs/vite#3924) where they load CSS in different order in a dev/prod environment. To fix this, I've added
:rootselector to the override, to make sure the specificity of it is higher than the original. I applied the fix also for other instances where we override this class.We also switched the hide behaviour of the dropdown from input blur to outside-click. This way user can grab the scrolling thumb without closing the dropdown. And implemented WebKit scrollbar styles to make sure the vertical scroll-bar doesn't disappear on Mac.