Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix loading executions in long execution list #5843

Merged
merged 4 commits into from
Mar 31, 2023
Merged

fix(editor): Fix loading executions in long execution list #5843

merged 4 commits into from
Mar 31, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Mar 30, 2023 •
edited
Loading

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 30, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (f8f584c) 14.98% compared to head (982d52c) 15.02%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5843      +/-   ##
==========================================
+ Coverage   14.98%   15.02%   +0.03%     
==========================================
  Files        2475     2476       +1     
  Lines      113403   113434      +31     
  Branches    17737    17742       +5     
==========================================
+ Hits        16997    17042      +45     
+ Misses      95828    95811      -17     
- Partials      578      581       +3

see 30 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mutdmour
mutdmour reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests please though

@MiloradFilipovic MiloradFilipovic merged commit 5c9343c into master Mar 31, 2023
@MiloradFilipovic MiloradFilipovic deleted the ADO-497-execution-loading-fix branch March 31, 2023 16:48
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 31, 2023
netroy pushed a commit that referenced this pull request Apr 3, 2023
@MiloradFilipovic @netroy
fix(editor): Fix loading executions in long execution list (#5843)
d5d9f58 
* fix(editor): Fix loading executions in long execution list
* ⚡ Added max number of attempts before displaying temporary execution card
* ⚡ Simplifying temp execution preview logic, handling current execution delete, updating style
* 💄 Renaming `executionWIthGap` -> `temporaryExecution`
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@MiloradFilipovic @believe-Mahesh
fix(editor): Fix loading executions in long execution list (n8n-io#5843)
47fbb97 
* fix(editor): Fix loading executions in long execution list
* ⚡ Added max number of attempts before displaying temporary execution card
* ⚡ Simplifying temp execution preview logic, handling current execution delete, updating style
* 💄 Renaming `executionWIthGap` -> `temporaryExecution`
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
aee8f35 
* master: (87 commits)
  ci: Always run e2e tests on PR approval (no-changelog) (#5900)
  fix(core): Improve axios error handling in nodes (#5891)
  fix(HTTP Request Node): Detect mime-type from streaming responses (#5896)
  fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs
  fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872)
  fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893)
  feat(Postgres Node): Overhaul node
  fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860)
  fix(core): Use table-prefixes in queries in import commands (#5887)
  fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807)
  fix(core): Fix the issue of nodes not loading when run via npx (#5888)
  fix(Gmail Node): Gmail luxon object support, fix for timestamp
  test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884)
  fix: Upgrade versions in pnpm-lock.yaml (no-changelog)
  Revert "fix(core): Improve axios error handling in nodes (#5699)"
  fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876)
  ci: Fix catch clause lint rule (#5875)
  fix(editor): Fix loading executions in long execution list (#5843)
  fix(HTTP Request Node): Support for dot notation in JSON body
  feat(SSH Node): Hide the private key within the ssh credential (#5871)
  ...

# Conflicts:
#	packages/nodes-base/credentials/Postgres.credentials.ts
#	packages/nodes-base/nodes/Postgres/Postgres.node.ts
#	packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts
#	packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/deleteTable.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/select.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
#	packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts
#	packages/nodes-base/nodes/Postgres/v2/helpers/utils.ts
#	packages/nodes-base/nodes/Postgres/v2/methods/index.ts
#	packages/nodes-base/nodes/Postgres/v2/transport/index.ts
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-399-resou…
10e2e8c 
…rce-mapper-ui

* feature/resource-mapping-component: (87 commits)
  ci: Always run e2e tests on PR approval (no-changelog) (#5900)
  fix(core): Improve axios error handling in nodes (#5891)
  fix(HTTP Request Node): Detect mime-type from streaming responses (#5896)
  fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs
  fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872)
  fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893)
  feat(Postgres Node): Overhaul node
  fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860)
  fix(core): Use table-prefixes in queries in import commands (#5887)
  fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807)
  fix(core): Fix the issue of nodes not loading when run via npx (#5888)
  fix(Gmail Node): Gmail luxon object support, fix for timestamp
  test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884)
  fix: Upgrade versions in pnpm-lock.yaml (no-changelog)
  Revert "fix(core): Improve axios error handling in nodes (#5699)"
  fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876)
  ci: Fix catch clause lint rule (#5875)
  fix(editor): Fix loading executions in long execution list (#5843)
  fix(HTTP Request Node): Support for dot notation in JSON body
  feat(SSH Node): Hide the private key within the ssh credential (#5871)
  ...

# Conflicts:
#	packages/editor-ui/src/constants.ts
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented Apr 19, 2023 •
edited
Loading

Got released with n8n@0.222.0

@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with n8n@0.222.1

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@MiloradFilipovic @sunilrr
fix(editor): Fix loading executions in long execution list (n8n-io#5843)
92b646e 
* fix(editor): Fix loading executions in long execution list
* ⚡ Added max number of attempts before displaying temporary execution card
* ⚡ Simplifying temp execution preview logic, handling current execution delete, updating style
* 💄 Renaming `executionWIthGap` -> `temporaryExecution`
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@MiloradFilipovic @sunilrr
fix(editor): Fix loading executions in long execution list (n8n-io#5843)
56587f1 
* fix(editor): Fix loading executions in long execution list
* ⚡ Added max number of attempts before displaying temporary execution card
* ⚡ Simplifying temp execution preview logic, handling current execution delete, updating style
* 💄 Renaming `executionWIthGap` -> `temporaryExecution`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MiloradFilipovic @janober @mutdmour