Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Prevent augmentObject from creating infinitely deep proxies #5893

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(core): Prevent augmentObject from creating infinitely deep proxies #5893

merged 1 commit into from
Apr 3, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 3, 2023

fixes #5848

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy added the skip-e2e label Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 58.82% and no project coverage change.

Comparison is base (ddbfcc7) 15.05% compared to head (da85d71) 15.06%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5893   +/-   ##
=======================================
  Coverage   15.05%   15.06%           
=======================================
  Files        2476     2476           
  Lines      113462   113464    +2     
  Branches    17744    17744           
=======================================
+ Hits        17087    17088    +1     
- Misses      95793    95794    +1     
  Partials      582      582
Impacted Files Coverage Δ
.../cli/src/eventbus/MessageEventBus/recoverEvents.ts 13.33% <ø> (ø)
packages/editor-ui/src/mixins/pushConnection.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/utils/nodeViewUtils.ts 0.00% <0.00%> (ø)
packages/workflow/src/AugmentObject.ts 93.67% <90.90%> (-1.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 3, 2023
@netroy netroy merged commit 31cd04c into master Apr 3, 2023
@netroy netroy deleted the PAY-333-fix-code-node-freezing branch April 3, 2023 15:18
netroy added a commit that referenced this pull request Apr 3, 2023
@netroy
fix(core): Prevent augmentObject from creating infinitely deep proxies (
b113b05 
#5893)

fixes #5848
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@netroy @believe-Mahesh
fix(core): Prevent augmentObject from creating infinitely deep proxies (
26a6205 
n8n-io#5893)

fixes n8n-io#5848
netroy added a commit that referenced this pull request Apr 4, 2023
@netroy
fix(core): Prevent augmentObject from creating infinitely deep proxies (
6906b00 
#5893)

fixes #5848
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
aee8f35 
* master: (87 commits)
  ci: Always run e2e tests on PR approval (no-changelog) (#5900)
  fix(core): Improve axios error handling in nodes (#5891)
  fix(HTTP Request Node): Detect mime-type from streaming responses (#5896)
  fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs
  fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872)
  fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893)
  feat(Postgres Node): Overhaul node
  fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860)
  fix(core): Use table-prefixes in queries in import commands (#5887)
  fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807)
  fix(core): Fix the issue of nodes not loading when run via npx (#5888)
  fix(Gmail Node): Gmail luxon object support, fix for timestamp
  test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884)
  fix: Upgrade versions in pnpm-lock.yaml (no-changelog)
  Revert "fix(core): Improve axios error handling in nodes (#5699)"
  fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876)
  ci: Fix catch clause lint rule (#5875)
  fix(editor): Fix loading executions in long execution list (#5843)
  fix(HTTP Request Node): Support for dot notation in JSON body
  feat(SSH Node): Hide the private key within the ssh credential (#5871)
  ...

# Conflicts:
#	packages/nodes-base/credentials/Postgres.credentials.ts
#	packages/nodes-base/nodes/Postgres/Postgres.node.ts
#	packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts
#	packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/deleteTable.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/select.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
#	packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts
#	packages/nodes-base/nodes/Postgres/v2/helpers/utils.ts
#	packages/nodes-base/nodes/Postgres/v2/methods/index.ts
#	packages/nodes-base/nodes/Postgres/v2/transport/index.ts
MiloradFilipovic added a commit that referenced this pull request Apr 4, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-399-resou…
10e2e8c 
…rce-mapper-ui

* feature/resource-mapping-component: (87 commits)
  ci: Always run e2e tests on PR approval (no-changelog) (#5900)
  fix(core): Improve axios error handling in nodes (#5891)
  fix(HTTP Request Node): Detect mime-type from streaming responses (#5896)
  fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs
  fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872)
  fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893)
  feat(Postgres Node): Overhaul node
  fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860)
  fix(core): Use table-prefixes in queries in import commands (#5887)
  fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807)
  fix(core): Fix the issue of nodes not loading when run via npx (#5888)
  fix(Gmail Node): Gmail luxon object support, fix for timestamp
  test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884)
  fix: Upgrade versions in pnpm-lock.yaml (no-changelog)
  Revert "fix(core): Improve axios error handling in nodes (#5699)"
  fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876)
  ci: Fix catch clause lint rule (#5875)
  fix(editor): Fix loading executions in long execution list (#5843)
  fix(HTTP Request Node): Support for dot notation in JSON body
  feat(SSH Node): Hide the private key within the ssh credential (#5871)
  ...

# Conflicts:
#	packages/editor-ui/src/constants.ts
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented Apr 5, 2023

Got released with n8n@0.222.1

1 similar comment
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with n8n@0.222.1

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@netroy @sunilrr
fix(core): Prevent augmentObject from creating infinitely deep proxies (
ee1a412 
n8n-io#5893)

fixes n8n-io#5848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n8n freezes when Code node tries to extend previous data
3 participants
@netroy @janober @flipswitchingmonkey