-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HTTP Request Node): Detect mime-type from streaming responses #5896
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5896 +/- ##
==========================================
- Coverage 15.25% 15.23% -0.03%
==========================================
Files 2494 2494
Lines 114033 114037 +4
Branches 17830 17833 +3
==========================================
- Hits 17400 17370 -30
- Misses 96041 96075 +34
Partials 592 592
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* master: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/nodes-base/credentials/Postgres.credentials.ts # packages/nodes-base/nodes/Postgres/Postgres.node.ts # packages/nodes-base/nodes/Postgres/test/v2/utils.test.ts # packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts # packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/deleteTable.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/select.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts # packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts # packages/nodes-base/nodes/Postgres/v2/helpers/utils.ts # packages/nodes-base/nodes/Postgres/v2/methods/index.ts # packages/nodes-base/nodes/Postgres/v2/transport/index.ts
…rce-mapper-ui * feature/resource-mapping-component: (87 commits) ci: Always run e2e tests on PR approval (no-changelog) (#5900) fix(core): Improve axios error handling in nodes (#5891) fix(HTTP Request Node): Detect mime-type from streaming responses (#5896) fix(Compare Datasets Node): Fuzzy compare not comparing keys missing in one of inputs fix(core): `augmentObject` should use existing property descriptors whenever possible (#5872) fix(core): Prevent augmentObject from creating infinitely deep proxies (#5893) feat(Postgres Node): Overhaul node fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) (#5860) fix(core): Use table-prefixes in queries in import commands (#5887) fix(AWS SNS Node): Fix an issue with messages failing to send if they contain certain characters (#5807) fix(core): Fix the issue of nodes not loading when run via npx (#5888) fix(Gmail Node): Gmail luxon object support, fix for timestamp test(editor): Fix failing licensing related e2e specs (no-changelog) (#5884) fix: Upgrade versions in pnpm-lock.yaml (no-changelog) Revert "fix(core): Improve axios error handling in nodes (#5699)" fix(editor): Update execution loading parameters after pushing test values (no-changelog) (#5876) ci: Fix catch clause lint rule (#5875) fix(editor): Fix loading executions in long execution list (#5843) fix(HTTP Request Node): Support for dot notation in JSON body feat(SSH Node): Hide the private key within the ssh credential (#5871) ... # Conflicts: # packages/editor-ui/src/constants.ts # pnpm-lock.yaml
Got released with |
Fixes #5894