Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP request binary mime type set incorrectly in version 0.222.0 #5894

Closed
MeesJ opened this issue Apr 3, 2023 · 1 comment · Fixed by #5896
Closed

HTTP request binary mime type set incorrectly in version 0.222.0 #5894

MeesJ opened this issue Apr 3, 2023 · 1 comment · Fixed by #5896
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@MeesJ
Copy link

MeesJ commented Apr 3, 2023

Describe the bug
Since I upgraded my n8n instance to 0.222.0 I'm having issues with the HTTP request node. To be specific, when the HTTP request node gets a binary file, it now incorrectly sets the mime type in n8n.

Getting a jpeg file before 0.222.0:

Getting a jpeg file after 0.222.0:

In both cases the content-type header from the file source is set to image/jpeg.

To Reproduce
Steps to reproduce the behavior:

  1. Create a workflow with a HTTP request node
  2. Execute the HTTP request node once you set it to get any binary file from any source
  3. See that the mime type in n8n is set to text/plain, regardless of the content-type header from the binary file source

Expected behavior
I expect n8n to look at the content-type header from the binary file source and use it to set the mime type within n8n.

Environment (please complete the following information):

  • OS: Ubuntu 22.04.02 LTS
  • n8n Version: 0.222.0
  • Node.js Version [e.g. 16.17.0]
  • Database system: MariaDB
  • Operation mode: main

Additional context

I have downgraded my n8n instance to 0.221.2 and I can confirm that this bug isn't present there.

@Joffcom
Copy link
Member

Joffcom commented Apr 3, 2023

Hey @MeesJ,

Thanks for the report, I have created an internal ticket for this which we will be tracking as NODE-440

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants