-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Add loading skeletons to Executions list page #6184
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
…ons-view-misleads-the
…ons-view-misleads-the
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6184 +/- ##
=======================================
Coverage 19.93% 19.93%
=======================================
Files 2646 2646
Lines 119664 119664
Branches 18928 18928
=======================================
Hits 23859 23859
Misses 95078 95078
Partials 727 727 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
✅ All Cypress E2E specs passed |
* master: feat(Google Ads Node): Update to support v13 (#6212) ci: Fix published nodes-base package's dependencies (no-changelog) (#6226) ci: Code coverage should include `.vue` files as well (no-changelog) (#6224) 🚀 Release 0.228.0 (#6219) ci: Fix linting issue on master (no-changelog) (#6222) fix(core): Ensure DB repositories are initialized before the DB migrations are run (#6220) refactor(editor): Stricter linting for promises and async functions (no-changelog) (#4642) ci: Increase timeout for DB tests (no-changelog) (#6221) fix(editor): Fix viewing and downloading of binary data (#6218) fix: Prevent unnecessary error messages also for data loaded flag (#6201) feat: Create NPM node (#6177) fix(editor): Fix polling trigger check for `runData` (#6130) ci: Fix linting issue on master (no-changelog) (#6217) fix: Prevent overflow when rendering expression hints (#6214) feat(core): Improve health check (#6205) refactor(editor): Add GitHub 30k stars banner (no-changelog) (#6204) fix(editor): Add loading skeletons to Executions list page (#6184) ci: Fix v1 docker rc builds (no-changelog) (#6208) feat(Code Node): Set `defaultVersion` to 2 for V1 RC builds (no-changelog) (#6209) fix: Correctly save executions that failed when polling as error instead of new (#6192) # Conflicts: # packages/editor-ui/src/components/ParameterInputList.vue
* fix(editor): Add loading skeletons to Executions list page * fix(editor): lint fix * fix(editor): fix loading * fix(editor): fix loading * fix(editor): fix keys * fix(editor): fix localization * fix(editor): fix key
Got released with |
No description provided.