fix(editor): Fix an issue with connections breaking during renaming #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive would break workflow connections
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6358 +/- ##
==========================================
- Coverage 28.32% 28.32% -0.01%
==========================================
Files 2982 2982
Lines 185125 185127 +2
Branches 20297 20297
==========================================
Hits 52443 52443
- Misses 131897 131899 +2
Partials 785 785
☔ View full report in Codecov by Sentry. |
cstuncsik
reviewed
Jun 1, 2023
cstuncsik
approved these changes
Jun 1, 2023
|
|
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 2, 2023
* master: fix(editor): Fix an issue with connections breaking during renaming (#6358) fix(core): Upgrade @n8n_io/riot-tmpl (no-changelog) (#6357) fix: Show actual execution data for production executions even if pin data exists (#6302) fix: Improve executions list polling performance (#6355) refactor: Revert 30k stars banner (no-changelog) (#6347) refactor: Add deprecation notice for basic auth and JWT auth (#6349) fix: Prevent redirect when outside of executions home (no-changelog) (#6305)
krynble
pushed a commit
that referenced
this pull request
Jun 5, 2023
…6358) * fix(editor): Fix an issue where dragging during when rename modal active would break workflow connections * Use enum to check for confirm state of modal
krynble
pushed a commit
that referenced
this pull request
Jun 6, 2023
…6358) * fix(editor): Fix an issue where dragging during when rename modal active would break workflow connections * Use enum to check for confirm state of modal
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue related to renaming nodes on the canvas. Previously, if a user initiated the rename process but then cancelled it,
promptResponse.valuewould becomeundefined, leading to a failure in therenameNodefunction.To remedy this, we've implemented a conditional check to ascertain that the user has indeed confirmed the renaming action. We will only proceed with the renaming operation if the user has clicked confirm.
Github issue / Community forum post (link here to close automatically):