-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Date & Time Node): Reset responseData at end of loop #6385
fix(Date & Time Node): Reset responseData at end of loop #6385
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6385 +/- ##
==========================================
- Coverage 28.33% 28.26% -0.08%
==========================================
Files 2980 2980
Lines 184969 184970 +1
Branches 20306 20306
==========================================
- Hits 52420 52290 -130
- Misses 131762 131893 +131
Partials 787 787
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
1 flaky tests on run #1127 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Undo/Redo > should undo/redo disabling a node using disable button |
Output
Screenshots
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
✅ All Cypress E2E specs passed |
* master: test(editor): Unit test Version control frontend components (#6408) fix: Fist name to First Name in certain nodes (no-changelog) (#6404) fix(core): Allow all executions to be stopped (#6386) fix(core): RMC boolean value fix (#6397) fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392) fix(Ldap Node): Add DN field to update operation (#6371) feat: New trigger PostgreSQL (#5495) build: Update pnpm lock file (no-changelog) (#6395) fix(Date & Time Node): Reset responseData at end of loop (#6385) refactor(core): Google service account remove duplicated functions (no-changelog) (#6368) refactor(LoneScale List Node)!: Rename to LoneScale (#6337) fix(editor): Update version control setup CTA tooltip (#6393) ci: Fix build (no-changelog) (#6391) fix(editor): Add button to refresh branches (#6387) fix(editor): Add Set up version control CTA (#6356) fix(editor): Remove explicit parameter name scanning for code editors (#6390) ci: Fix build (no-changelog) (#6379) fix(editor): Adding branch color (#6380) refactor(editor): Remove user activation modal (no-changelog) (#6361) feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
Got released with |
reset responseData at end of loop
Github issue / Community forum post (link here to close automatically):
#6384