fix(core): Update docker compose setup for V1 images #6642
Conversation
netroy
force-pushed
the
v1-docker-compose
branch
from
418d66d
to
4a41e99
Compare
netroy
force-pushed
the
v1-docker-compose
branch
from
4a41e99
to
953650b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6642 +/- ##
==========================================
- Coverage 28.93% 28.86% -0.08%
==========================================
Files 3071 3071
Lines 188445 188451 +6
Branches 20893 20890 -3
==========================================
- Hits 54532 54396 -136
- Misses 133033 133175 +142
Partials 880 880
☔ View full report in Codecov by Sentry. |
| @@ -39,7 +39,6 @@ services: | |||
| - postgres | |||
| volumes: | |||
| - n8n_storage:/home/node/.n8n | |||
| command: /bin/sh -c "n8n start --tunnel" | |||
There was a problem hiding this comment.
We're losing the --tunnel capability, aren't we?
There was a problem hiding this comment.
our tunnel servers seem overwhelmed. I haven't managed to get them working for a while.
There was a problem hiding this comment.
Ah damn, maybe we should switch to something like ngrok if it's possible instead of trying to host it ourselves.
There was a problem hiding this comment.
it could be that's localtunnel is simply not working for me. I can put the --tunnel option back if you prefer. but I think people running either of these docker-compose stacks need a tunnel url. I always assumed that was for user running n8n via npx.
There was a problem hiding this comment.
I just tried starting n8n with --tunnel and I get a URL but it won't work to load n8n. So I think we should continue with the --tunnel flag, and tell users that we're having issues maintaining this service rather than just removing it without prior notice WDYT @netroy ?
There was a problem hiding this comment.
I'm working on bringing this back, once the app uses the tunnel url correctly throughout.
|
I haven't tried starting up the services tho, please let me know if you want me to test this as well. |
1 flaky tests on run #1426 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Expression editor modal > should resolve object resolvables |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
* master: ci!: Drop support for Node.js 16. Add initial support for Node.js 20 (#6649) feat(API): Implement users account quota guards (#6434) feat(OpenAI Node): Update max token limit to support newer model limits (#6644) ci: Run checklist job as a separate workflow (no-changelog) (#6645) fix(HTTP Request Node): Cleanup circular references in response (#6590) fix(Postgres Node): Upsert does not fetch columns when schema other then public (#6643) fix(core): Update docker compose setup for V1 images (#6642) refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) fix(core): Reduce memory consumption on `BinaryDataManager.init` (#6633) fix(editor): Implement simple view for templates experiment (no-changelog) (#6637) # Conflicts: # packages/editor-ui/src/stores/settings.store.ts
|
Got released with |
* ADO-814-trial-banner: ✔️ Updated callout component snapshots 👌 Moving DOM logic from the store 👌 Addressing more points from code review 👌 Refactoring trial banner component and ui store 👌 Updating permanent banner dismiss endpoint and back-end logic ⚡ Updating the migrations syntax ci!: Drop support for Node.js 16. Add initial support for Node.js 20 (#6649) feat(API): Implement users account quota guards (#6434) feat(OpenAI Node): Update max token limit to support newer model limits (#6644) ci: Run checklist job as a separate workflow (no-changelog) (#6645) fix(HTTP Request Node): Cleanup circular references in response (#6590) fix(Postgres Node): Upsert does not fetch columns when schema other then public (#6643) fix(core): Update docker compose setup for V1 images (#6642) refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) fix(core): Reduce memory consumption on `BinaryDataManager.init` (#6633) ⚡ Updating upgrade plan button click 👌 Addressing design review feedback ⚡ Using query parameters in migrations fix(editor): Implement simple view for templates experiment (no-changelog) (#6637) ⚡ Updating migration files
fixes #6641