refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) #6631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
commented
Jul 10, 2023
| @@ -1319,22 +1319,22 @@ export class Gitlab implements INodeType { | |||
| const items = this.getInputData(); | |||
| const returnData: INodeExecutionData[] = []; | |||
|
|
|||
| let _credentials; | |||
There was a problem hiding this comment.
since _credentials used anywhere, is this dead-code copy-pasted from elsewhere?
There was a problem hiding this comment.
Looks like it might be taken from a credential test
netroy
changed the title
netroy
commented
Jul 10, 2023
| @@ -373,7 +373,7 @@ export class CrateDb implements INodeType { | |||
| returning, | |||
| ); | |||
| } | |||
| const _updateItems = await db.multi(pgp.helpers.concat(queries)); | |||
| // const _updateItems = await db.multi(pgp.helpers.concat(queries)); | |||
There was a problem hiding this comment.
Looks like it, I don't have a cratedb instance running locally but I can't it being used anywhere else.
n8n-assistant
bot
added
core
…unused code in nodes-base (no-changelog)
netroy
force-pushed
the
remove-reexported-interfaces-from-core
branch
from
41bc060
to
0496bc3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6631 +/- ##
==========================================
- Coverage 28.93% 28.87% -0.07%
==========================================
Files 3071 3071
Lines 188445 188434 -11
Branches 20893 20889 -4
==========================================
- Hits 54532 54402 -130
- Misses 133033 133152 +119
Partials 880 880
☔ View full report in Codecov by Sentry. |
Joffcom
approved these changes
Jul 12, 2023
Passing run #1427 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 12, 2023
* master: ci!: Drop support for Node.js 16. Add initial support for Node.js 20 (#6649) feat(API): Implement users account quota guards (#6434) feat(OpenAI Node): Update max token limit to support newer model limits (#6644) ci: Run checklist job as a separate workflow (no-changelog) (#6645) fix(HTTP Request Node): Cleanup circular references in response (#6590) fix(Postgres Node): Upsert does not fetch columns when schema other then public (#6643) fix(core): Update docker compose setup for V1 images (#6642) refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) fix(core): Reduce memory consumption on `BinaryDataManager.init` (#6633) fix(editor): Implement simple view for templates experiment (no-changelog) (#6637) # Conflicts: # packages/editor-ui/src/stores/settings.store.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 13, 2023
* ADO-814-trial-banner: ✔️ Updated callout component snapshots 👌 Moving DOM logic from the store 👌 Addressing more points from code review 👌 Refactoring trial banner component and ui store 👌 Updating permanent banner dismiss endpoint and back-end logic ⚡ Updating the migrations syntax ci!: Drop support for Node.js 16. Add initial support for Node.js 20 (#6649) feat(API): Implement users account quota guards (#6434) feat(OpenAI Node): Update max token limit to support newer model limits (#6644) ci: Run checklist job as a separate workflow (no-changelog) (#6645) fix(HTTP Request Node): Cleanup circular references in response (#6590) fix(Postgres Node): Upsert does not fetch columns when schema other then public (#6643) fix(core): Update docker compose setup for V1 images (#6642) refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) fix(core): Reduce memory consumption on `BinaryDataManager.init` (#6633) ⚡ Updating upgrade plan button click 👌 Addressing design review feedback ⚡ Using query parameters in migrations fix(editor): Implement simple view for templates experiment (no-changelog) (#6637) ⚡ Updating migration files
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.