Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Remove additional margin on tooltip #6802

Merged

Conversation

cstuncsik
Copy link
Contributor

Element UI+ tooltip has a default 12px offset, the old had 0

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (dc295ac) 24.62% compared to head (f4dd9cc) 24.62%.
Report is 2 commits behind head on master.

❗ Current head f4dd9cc differs from pull request most recent head 541f143. Consider uploading reports for the commit 541f143 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
- Coverage   24.62%   24.62%   -0.01%     
==========================================
  Files        3122     3121       -1     
  Lines      190461   190417      -44     
  Branches    20930    20921       -9     
==========================================
- Hits        46903    46885      -18     
+ Misses     142630   142608      -22     
+ Partials      928      924       -4     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 31, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jul 31, 2023

1 flaky tests on run #1687 ↗︎

0 221 0 0 Flakiness 1

Details:

🌳 n8n-6783-tooltips-are-to-far-from-triggering-content 🖥️ browsers:node18.12.0...
Project: n8n Commit: 541f143d20
Status: Passed Duration: 07:58 💡
Started: Jul 31, 2023 12:53 PM Ended: Jul 31, 2023 1:01 PM
Flakiness  cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 651cf34 into master Jul 31, 2023
17 checks passed
@cstuncsik cstuncsik deleted the n8n-6783-tooltips-are-to-far-from-triggering-content branch July 31, 2023 13:10
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with n8n@1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants