Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Redirect to workflow editor after saving in debug mode #7645

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 7, 2023
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and the code looks good.

Copy link

cypress bot commented Nov 8, 2023

4 flaky tests on run #2778 ↗︎

0 271 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 3b8c46c718
Status: Passed Duration: 07:39 💡
Started: Nov 8, 2023 12:55 PM Ended: Nov 8, 2023 1:03 PM
Flakiness  6-code-node.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
Code node > Code editor > should execute the placeholder successfully in both modes Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 2 flaky tests

View
Output
Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video
Resource Mapper > should correctly delete all fields Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
Current Workflow Executions > should render executions tab correctly Screenshots Video

Review all test suite changes for PR #7645 ↗︎

Copy link
Contributor

github-actions bot commented Nov 8, 2023

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 020042e into master Nov 8, 2023
55 of 56 checks passed
@cstuncsik cstuncsik deleted the pay-868-bug-debugger-stuck-in-route branch November 8, 2023 13:04
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
ivov added a commit that referenced this pull request Nov 15, 2023
#
[1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0)
(2023-11-15)


### Bug Fixes

* **Convert to/from binary data Node:** Better mime type defaults
([#7693](#7693))
([9b3be0c](9b3be0c))
* **core:** Consider subworkflows successfully run when in waiting state
([#7699](#7699))
([0e00dab](0e00dab))
* **core:** Fix named parameter resolution in migrations
([#7688](#7688))
([4441ed5](4441ed5)),
closes [#7628](#7628)
* **core:** Initialize JWT Secret before it's used anywhere
([#7707](#7707))
([3460eb5](3460eb5))
* **core:** Reduce memory usage in credentials risk auditing
([#7663](#7663))
([9fd6319](9fd6319))
* **Date & Time Node:** Add fromFormat option to solve ambiguous date
strings ([#7675](#7675))
([d2d11e0](d2d11e0))
* **editor:** Fix resource mapper component being truncated
([#7664](#7664))
([00dff50](00dff50))
* **editor:** More securely clear executions tab auto refresh timer
([#7685](#7685))
([37dd658](37dd658))
* **editor:** Redirect to workflow editor after saving in debug mode
([#7645](#7645))
([020042e](020042e))
* **Google Sheets Node:** Append exceeding grid limits
([#7684](#7684))
([88efb99](88efb99))
* **HTTP Request Node:** Support generic credentials when using
pagination ([#7686](#7686))
([48b240b](48b240b)),
closes [#7653](#7653)
* **HubSpot Node:** Fetching available parameters fails when using
expressions ([#7672](#7672))
([a9ab738](a9ab738))
* **HubSpot Node:** Update deal owner on Hubspot Deal
([#7673](#7673))
([3c0734b](3c0734b))
* **Spreadsheet File Node:** Read file as utf-8 in v1
([#7701](#7701))
([786b4ad](786b4ad))


### Features

* **core:** Expression function $ifEmpty
([#7660](#7660))
([1c7225e](1c7225e))
* **Date & Time Node:** Option to include other fields in output item
([#7661](#7661))
([aea3c50](aea3c50))
* **Discord Node:** Overhaul
([#5351](#5351))
([6a53c2a](6a53c2a))
* **Discourse Node:** Add new options to Get Users
([#7674](#7674))
([2e8c841](2e8c841))
* **editor:** Add color selector to sticky node
([#7453](#7453))
([8359364](8359364))
* **editor:** Add HTTP request nodes for credentials without a node
([#7157](#7157))
([14035e1](14035e1))
* **editor:** Add workflow filters to querystring
([#7456](#7456))
([afd637b](afd637b))
* **editor:** Adds a EE view to show worker details and job status
([#7600](#7600))
([cbc6909](cbc6909))
* **GitLab Node:** Add support for pagination on getIssues
([#7529](#7529))
([0a0798e](0a0798e))
* **OpenAI Node:** Add dall-e-3 support
([#7655](#7655))
([a9c7188](a9c7188))
* **RabbitMQ Trigger Node:** Add exchange and routing key options
([#7547](#7547))
([5aee2b7](5aee2b7))
* **Telegram Node:** Add support for markdownv2
([#7679](#7679))
([819b3a7](819b3a7))
* **Venafi TLS Protect Cloud Node:** Add region parameter to Venafi
protect cloud ([#7689](#7689))
([a08fca5](a08fca5))


### Performance Improvements

* **core:** Lazyload security audit reporters
([#7696](#7696))
([b2ca050](b2ca050))

Co-authored-by: ivov <ivov@users.noreply.github.com>
@janober
Copy link
Member

janober commented Nov 15, 2023

Got released with n8n@1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants