Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Chat Memory Manager node #8127

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Dec 21, 2023

Summary

This PR implements Chat Memory Manager to allow for retrieving and mutating of a chat memory in the main flow.
It replaces the old Chat Messages Retriever and adds two additional operations: in(up)sert and delete.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 21, 2023
@OlegIvaniv OlegIvaniv marked this pull request as draft January 8, 2024 12:07
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv marked this pull request as ready for review January 10, 2024 15:44
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Jan 11, 2024

3 flaky tests on run #3723 ↗︎

0 332 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: d8cd8f8232
Status: Passed Duration: 03:29 💡
Started: Jan 11, 2024 1:28 PM Ended: Jan 11, 2024 1:32 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Test Replay Screenshots Video

Review all test suite changes for PR #8127 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 464be93 into master Jan 15, 2024
28 checks passed
@michael-radency michael-radency deleted the ai-memory-manager-rebased branch January 15, 2024 08:13
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
@janober
Copy link
Member

janober commented Jan 17, 2024

Got released with n8n@1.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants