fix(FTP Node): FTP connection failed due to missing password credential in node

[vacitbaydarman]

Summary

The credentials have been defined in the setup, but the password data was not passed to the connect method. As a result, the node throws the following exception.

Error: connect->getConnection: All configured authentication methods failed
at fmtError (/Users/mehmetvacitbaydarman/Desktop/FiWork/Azure/Fi.N8n/node_modules/.pnpm/ssh2-sftp-client@7.2.3/node_modules/ssh2-sftp-client/src/utils.js:55:18)
at SftpClient.connect (/Users/mehmetvacitbaydarman/Desktop/FiWork/Azure/Fi.N8n/node_modules/.pnpm/ssh2-sftp-client@7.2.3/node_modules/ssh2-sftp-client/src/index.js:218:13)
at Object.execute (/Users/mehmetvacitbaydarman/Desktop/FiWork/Azure/Fi.N8n/packages/nodes-base/nodes/Ftp/Ftp.node.ts:519:6)
at Workflow.runNode (/Users/mehmetvacitbaydarman/Desktop/FiWork/Azure/Fi.N8n/packages/workflow/src/Workflow.ts:1307:8)
at /Users/mehmetvacitbaydarman/Desktop/FiWork/Azure/Fi.N8n/packages/core/src/WorkflowExecute.ts:1061:29

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

• PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.

  A bug is not considered fixed, unless a test is added to prevent it from happening again.
  A feature is not complete without tests.

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @vacitbaydarman,

Thanks for the PR, I have just taken a quick look connecting to an SFTP server using a private key and it is working as expected. Looking at this PR it shouldn't cause anything to break but it would be nice to have a bit more context behind this one, Typically an SFTP server would be configured to accept either key or password based authentication in your configuration is the user password also required when performing key based authentication?

[vacitbaydarman]

Hi Jon, Actually, in our development and test environments also it is working as you said. But in production, we are using another server from a third party and we could not connect to their sftp server without passing the password with a private key. According to my research, some companies can need a password and private key at the same time and our third party company that we want to access track this way. So, if this does not affect the other connector, we are appreciative of you to apply this PR to not face this issue again at the next version upgrade. I tested both of them and it seems good for both behaviour (privatekey and password+privatekey) Best regards, *Mehmet Vacit Baydarman* Solution Architect Jon ***@***.***>, 2 Oca 2024 Sal, 11:59 tarihinde şunu yazdı:

…

Hey @vacitbaydarman <https://github.com/vacitbaydarman>, Thanks for the PR, I have just taken a quick look connecting to an SFTP server using a private key and it is working as expected. Looking at this PR it shouldn't cause anything to break but it would be nice to have a bit more context behind this one, Typically an SFTP server would be configured to accept either key or password based authentication in your configuration is the user password also required when performing key based authentication? — Reply to this email directly, view it on GitHub <#8131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A32TR2NQIYAUXSGCF25B63TYMPEAVAVCNFSM6AAAAABA6VSTY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTG42TMMBTG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- The content of this e-mail and its attachments is intended only for the addressee(s) and may contain confidential or private information. You have no right to forward, copy, distribute, disclose, store, or use any part of this message, if you are not the intended addressee. If you have received this correspondence in error, please delete the message and all copies of it from your system and notify the sender immediately. The delivery of this message cannot be guaranteed to be timely, secure and error or virus-free. The sender accepts no liability for any errors or omissions that may occur.

[Joffcom]

Hey @vacitbaydarman,

Perfect thanks, I wondered if that was the case and I was thinking back to my old managed file transfer days around some of the settings that were commonly used and I don't think I ever had a case where someone wanted to use use both key based and password based for the same session 😄

I will give this another test in the morning to make sure it is all good but I can't see this breaking anything.

[vacitbaydarman]

Hi Jon, That great, I agree with you 😀 So, I will wait for your response to be sure that the issue has been resolved forever. Thanks a lot for your collaboration. Best regards, *Mehmet Vacit Baydarman* Solution Architect Jon ***@***.***>, 2 Oca 2024 Sal, 19:27 tarihinde şunu yazdı:

…

Hey @vacitbaydarman <https://github.com/vacitbaydarman>, Perfect thanks, I wondered if that was the case and I was thinking back to my old managed file transfer days around some of the settings that were commonly used and I don't think I ever had a case where someone wanted to use use both key based and password based for the same session 😄 I will give this another test in the morning to make sure it is all good but I can't see this breaking anything. — Reply to this email directly, view it on GitHub <#8131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A32TR2K2PWYKOQEPKENUTULYMQYQHAVCNFSM6AAAAABA6VSTY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGI2TANZVG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- The content of this e-mail and its attachments is intended only for the addressee(s) and may contain confidential or private information. You have no right to forward, copy, distribute, disclose, store, or use any part of this message, if you are not the intended addressee. If you have received this correspondence in error, please delete the message and all copies of it from your system and notify the sender immediately. The delivery of this message cannot be guaranteed to be timely, secure and error or virus-free. The sender accepts no liability for any errors or omissions that may occur.