Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small ui fixes to workflow cred setup modal (no-changelog) #8280

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Jan 9, 2024

Summary

  • Change title from Setup to Set up
  • Add Continue button
  • Make modal narrower with smaller margin

Before:

image

After:

image

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

- Change title from Setup to Set up
- Add Continue button
- Make modal narrower with smaller margin
@tomi tomi requested a review from mutdmour January 9, 2024 16:14
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 9, 2024
Copy link

cypress bot commented Jan 9, 2024

1 flaky test on run #3677 ↗︎

0 330 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project: n8n Commit: 1d9693fc79
Status: Passed Duration: 06:54 💡
Started: Jan 9, 2024 4:24 PM Ended: Jan 9, 2024 4:30 PM
Flakiness  cypress/e2e/29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8280 ↗︎

Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ All Cypress E2E specs passed

@tomi tomi merged commit 23abd8f into master Jan 9, 2024
19 checks passed
@tomi tomi deleted the ado-1463-cred-setup-modal-ui-fixes branch January 9, 2024 16:32
MiloradFilipovic added a commit that referenced this pull request Jan 10, 2024
* master:
  ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271)
  fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280)
  fix: Fix issue with API key being required for the Qdrant Node (#8237)
  feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771)
  fix(FTP Node): FTP connection failed due to missing password credential in node (#8131)
  ci: Fix lint setup in `chat` package (no-changelog) (#8275)
  ci: Fix codecov reporting, and include all packages (no-changelog) (#8276)
  fix(core): Fix test webhook deregistration (#8247)
  docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273)
  fix: Fix user reinvites on FE and BE (#8261)
  docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270)
  feat: Add Chat Trigger node (#7409)
  fix(Github Trigger Node): Enforce SSL validation by default (#8265)
  fix(editor): Tweaking button sizes in execution preview (#8206)
  fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants