Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Validate docs urls for langchain nodes as well (no-changelog) #8271

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 9, 2024

Summary

This PR updates the docs url validation script to now also validate urls for credentials and nodes in the new langchain package.
also, this speeds up the url validation script.

Test Run

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 9, 2024
tomi
tomi previously approved these changes Jan 9, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 One small suggestion

.github/scripts/validate-docs-links.js Show resolved Hide resolved
.github/scripts/validate-docs-links.js Outdated Show resolved Hide resolved
Copy link

cypress bot commented Jan 9, 2024

1 flaky test on run #3679 ↗︎

0 330 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 20be04214b
Status: Passed Duration: 06:55 💡
Started: Jan 9, 2024 5:26 PM Ended: Jan 9, 2024 5:32 PM
Flakiness  cypress/e2e/29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8271 ↗︎

Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit f208a6e into master Jan 9, 2024
21 checks passed
@netroy netroy deleted the check-langchain-docs-urls branch January 9, 2024 18:17
MiloradFilipovic added a commit that referenced this pull request Jan 10, 2024
* master:
  ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271)
  fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280)
  fix: Fix issue with API key being required for the Qdrant Node (#8237)
  feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771)
  fix(FTP Node): FTP connection failed due to missing password credential in node (#8131)
  ci: Fix lint setup in `chat` package (no-changelog) (#8275)
  ci: Fix codecov reporting, and include all packages (no-changelog) (#8276)
  fix(core): Fix test webhook deregistration (#8247)
  docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273)
  fix: Fix user reinvites on FE and BE (#8261)
  docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270)
  feat: Add Chat Trigger node (#7409)
  fix(Github Trigger Node): Enforce SSL validation by default (#8265)
  fix(editor): Tweaking button sizes in execution preview (#8206)
  fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants