Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Execute Workflow Node): Add 'Wait For Sub-Workflow Completion' option #8389

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 18, 2024

Summary

image

Related tickets and issues

https://linear.app/n8n/issue/NODE-955/execute-workflow-node-allow-returning-immediately-without-results

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 18, 2024
…execute-workflow-node-allow-returning-immediately-without
…execute-workflow-node-allow-returning-immediately-without
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Jan 19, 2024

3 flaky tests on run #3829 ↗︎

0 336 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 168c0791e4
Status: Passed Duration: 03:21 💡
Started: Jan 19, 2024 8:23 AM Ended: Jan 19, 2024 8:26 AM
Flakiness  30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Executions Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8389 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit ff92fc7 into master Jan 19, 2024
28 checks passed
@elsmr elsmr deleted the node-955-execute-workflow-node-allow-returning-immediately-without branch January 19, 2024 13:31
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
@janober
Copy link
Member

janober commented Jan 24, 2024

Got released with n8n@1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants