fix(editor): Fix opening of chat window when executing a child node #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
n8n-assistant
bot
added
n8n team
…agent-connected-to-chat
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
1 flaky test on run #4422 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8789 ↗︎
…agent-connected-to-chat
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
…g-executing-node-not-workflow-on-agent-connected-to-chat
…g-executing-node-not-workflow-on-agent-connected-to-chat
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-125-bug-executing-node-not-workflow-on-agent-connected-to-chat
branch
krynble
pushed a commit
that referenced
this pull request
Mar 25, 2024
…8789) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Michael Kret <michael.k@radency.com>
Merged
|
Got released with |
This was referenced Mar 27, 2024
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve logic for opening the chat modal if the manually executed node is a child of the chat trigger. During manual node execution, we check if the starting node(chat trigger) has run or pin data, and if it doesn't, we open the chat modal.
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)