Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Update User's Profile not passing user to API #8907

Closed
troylar opened this issue Mar 15, 2024 · 3 comments
Closed

Slack Update User's Profile not passing user to API #8907

troylar opened this issue Mar 15, 2024 · 3 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@troylar
Copy link

troylar commented Mar 15, 2024

Bug Description

When updating a profile in Slack, the user property is not getting set correctly in the API call.

To Reproduce

According to the API spec, user should be passed as a parameter. It's currently NOT being passed at all and so all changes to the profile are being made to the API user.

Expected behavior

When setting the user property, the profile should update the correct user.

Operating System

Linux

n8n Version

1.33.0

Node.js Version

18

Database

SQLite (default)

Execution mode

main (default)

@troylar
Copy link
Author

troylar commented Mar 15, 2024

The user property needs to be set here:

if (operation === 'updateProfile') {

@Joffcom
Copy link
Member

Joffcom commented Mar 19, 2024

Hey @troylar,

Thanks for the report, I have taken a quick look and it looks like we do set the user but in the wrong place. It looks like we add it to the profile body instead of at the top level.

I have created NODE-1246 as the internal dev ticket to fix this for a future release.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Mar 19, 2024
@janober
Copy link
Member

janober commented Oct 9, 2024

Fix got released with n8n@1.63.0

@Joffcom Joffcom closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

3 participants