Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 credential test #8941

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 credential test #8941

merged 2 commits into from
Mar 21, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Mar 21, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 21, 2024
@cypress Cypress
Copy link

cypress bot commented Mar 21, 2024

1 flaky test on run #4434 ↗︎

0 343 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 00fbbff365
Status: Passed Duration: 03:53 💡
Started: Mar 21, 2024 12:04 PM Ended: Mar 21, 2024 12:08 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8941 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 079a114 into master Mar 21, 2024
28 checks passed
@ivov ivov deleted the pay-1452-bug-credentials-that-do-not-have-a-test-method-should-show branch March 21, 2024 12:49
MiloradFilipovic added a commit that referenced this pull request Mar 21, 2024
@MiloradFilipovic
Merge branch 'master' into ADO-2073-fetch-cloud-role
5a9fbee 
* master:
  fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 credential test (#8941)
  fix(MySQL Node): Set paired items correctly in single query batch mode (#8940)
  docs: Fix the Microsoft OneDrive Trigger docs link (#8930)
krynble pushed a commit that referenced this pull request Mar 25, 2024
@ivov @krynble
fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 c…
578f01a 
…redential test (#8941)
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Merged
@janober
Copy link
Member

janober commented Mar 25, 2024

Got released with n8n@1.34.1

This was referenced Mar 27, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivov @janober @krynble