Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HighLevel Node): Api v2 support, new node version #9554

Conversation

michael-radency
Copy link
Contributor

Summary

update to support api v2 and OAuth2

Related tickets and issues

https://linear.app/n8n/issue/NODE-783/enterprise-request-support-for-highlevel-api-v2

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels May 30, 2024
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work great 🚀, some minor code comments

@@ -149,3 +149,10 @@ export const TEST_WEBHOOK_TIMEOUT = 2 * TIME.MINUTE;
export const TEST_WEBHOOK_TIMEOUT_BUFFER = 30 * TIME.SECOND;

export const N8N_DOCS_URL = 'https://docs.n8n.io';

export const GENERIC_OAUTH2_CREDENTIALS_WITH_EDDITABLE_SCOPE = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
export const GENERIC_OAUTH2_CREDENTIALS_WITH_EDDITABLE_SCOPE = [
export const GENERIC_OAUTH2_CREDENTIALS_WITH_EDITABLE_SCOPE = [

packages/nodes-base/nodes/HighLevel/v2/GenericFunctions.ts Outdated Show resolved Hide resolved
Copy link

cypress bot commented Jun 3, 2024

Passing run #5256 ↗︎

0 362 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: 8c06bdbb43
Status: Passed Duration: 04:28 💡
Started: Jun 3, 2024 8:40 AM Ended: Jun 3, 2024 8:45 AM

Review all test suite changes for PR #9554 ↗︎

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 19e5c03 into master Jun 3, 2024
28 checks passed
@michael-radency michael-radency deleted the node-783-enterprise-request-support-for-highlevel-api-v2-node-update branch June 3, 2024 09:09
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with n8n@1.45.0

@Felizolinha
Copy link

Felizolinha commented Jun 17, 2024

This is not available in the docker release for n8n@1.46.0 nor n8n@1.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants