fix(Jira Software Node): Fix comments limit and add sorting #9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
Joffcom
approved these changes
Jun 5, 2024
Merged
|
Got released with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the comments limit which doesn't currently work. It appears it was borrowed from the Issue getAll which uses a POST request with
maxResultsin the body. The comments endpoint is GET only, changing maxResults to a query param works correctly.The other change is to add the ability to sort by created ascending/descending (the only sort option for this endpoint). It maintains the default sort order (ascending).
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)