Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Remove streaming response #5663

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix(HTTP Request Node): Remove streaming response #5663

merged 1 commit into from
Mar 10, 2023

Conversation

agobrech
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/n8n-crashes-when-http-node-is-using-mattermost-credentials/23954

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited by agobrech
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title fix(Http Request Node): Remove streaming response fix(HTTP Request Node): Remove streaming response Mar 10, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 10, 2023
@netroy netroy merged commit 8a21fef into master Mar 10, 2023
@netroy netroy deleted the fix-remove-useStream-http-node branch March 10, 2023 10:54
netroy added a commit that referenced this pull request Mar 10, 2023
@netroy
Revert "fix(HTTP Request Node): Remove streaming response (#5663)"
7f6e116 
This reverts commit 8a21fef.
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
netroy pushed a commit that referenced this pull request Mar 10, 2023
@agobrech @netroy
fix(HTTP Request Node): Remove streaming response (#5663)
974d57d 
Remove useStream option from requestOptions
@janober
Copy link
Member

janober commented Mar 10, 2023

Got released with n8n@0.219.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
agobrech added a commit that referenced this pull request Mar 15, 2023
@agobrech
Revert "fix(HTTP Request Node): Remove streaming response (#5663)"
8b8fcb4 
This reverts commit 8a21fef.
agobrech added a commit that referenced this pull request Mar 21, 2023
@agobrech
fix(HTTP Request Node): Add streaming to binary response (#5701)
199a91b 
Revert "fix(HTTP Request Node): Remove streaming response  (#5663)"

This reverts commit 8a21fef.
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.219.1

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@agobrech @sunilrr
fix(HTTP Request Node): Remove streaming response (n8n-io#5663)
f851f62 
Remove useStream option from requestOptions
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@agobrech @sunilrr
fix(HTTP Request Node): Add streaming to binary response (n8n-io#5701)
1b1446a 
Revert "fix(HTTP Request Node): Remove streaming response  (n8n-io#5663)"

This reverts commit 8a21fef.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agobrech @janober @netroy