Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Google Sheets Node): Operations naming update (no-changelog) #7211

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

gandreini
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 19, 2023
@cypress
Copy link

cypress bot commented Sep 20, 2023

1 flaky test on run #2222 ↗︎

0 234 3 0 Flakiness 1

Details:

🌳 node-787-google-sheets-node-operations-naming 🖥️ browsers:node18.12.0-chrome...
Project: n8n Commit: b0d52a9ad0
Status: Passed Duration: 08:53 💡
Started: Sep 20, 2023 12:00 PM Ended: Sep 20, 2023 12:09 PM
Flakiness  cypress/e2e/28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@gandreini gandreini merged commit 09a7cf0 into master Sep 20, 2023
51 of 52 checks passed
@gandreini gandreini deleted the node-787-google-sheets-node-operations-naming branch September 20, 2023 13:20
MiloradFilipovic added a commit that referenced this pull request Sep 20, 2023
* master:
  refactor(core): Implement soft-deletions for executions (#7092)
  docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
  fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217)
  fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196)
  fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
  feat(Linear Node): Add support for OAuth2 (#7201)
  refactor: Ignore large-scale revisions (no-changelog) (#7210)
  fix(core): Resolve domains to IPv4 first (#7206)
  ci: Fix tests failing on MySQL (no-changelog) (#7208)
  feat(Set Node): Overhaul (#6348)
  fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
netroy pushed a commit that referenced this pull request Sep 21, 2023
)

Github issue / Community forum post (link here to close automatically):
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants