Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix tests failing on MySQL (no-changelog) #7208

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 19, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 62.89% and project coverage change: +0.03% 🎉

Comparison is base (cf776b8) 32.65% compared to head (b5e91e9) 32.69%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7208      +/-   ##
==========================================
+ Coverage   32.65%   32.69%   +0.03%     
==========================================
  Files        3340     3346       +6     
  Lines      199463   199748     +285     
  Branches    21850    21889      +39     
==========================================
+ Hits        65133    65298     +165     
- Misses     133250   133355     +105     
- Partials     1080     1095      +15     
Files Changed Coverage Δ
packages/cli/src/License.ts 51.75% <ø> (ø)
...es/editor-ui/src/components/ParameterInputList.vue 54.66% <0.00%> (-0.31%) ⬇️
...des/Code/descriptions/JavascriptCodeDescription.ts 100.00% <ø> (ø)
...e/nodes/Code/descriptions/PythonCodeDescription.ts 100.00% <ø> (ø)
packages/nodes-base/nodes/CrateDb/CrateDb.node.ts 0.00% <ø> (ø)
...uery/v2/actions/database/executeQuery.operation.ts 41.89% <ø> (ø)
...odes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/MySql/v1/MySqlV1.node.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Postgres/v1/PostgresV1.node.ts 0.00% <ø> (ø)
...ges/nodes-base/nodes/Postgres/v2/actions/router.ts 0.00% <0.00%> (ø)
... and 20 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 19, 2023

Passing run #2215 ↗︎

0 234 3 0 Flakiness 0

Details:

🌳 fix-tests-failing-on-mysql 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e...
Project: n8n Commit: b5e91e9f7d
Status: Passed Duration: 08:28 💡
Started: Sep 19, 2023 1:21 PM Ended: Sep 19, 2023 1:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 28598ed into master Sep 19, 2023
53 checks passed
@ivov ivov deleted the fix-tests-failing-on-mysql branch September 19, 2023 13:42
MiloradFilipovic added a commit that referenced this pull request Sep 20, 2023
* master:
  refactor(core): Implement soft-deletions for executions (#7092)
  docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
  fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217)
  fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196)
  fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
  feat(Linear Node): Add support for OAuth2 (#7201)
  refactor: Ignore large-scale revisions (no-changelog) (#7210)
  fix(core): Resolve domains to IPv4 first (#7206)
  ci: Fix tests failing on MySQL (no-changelog) (#7208)
  feat(Set Node): Overhaul (#6348)
  fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants