Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix editor tests when coverage is enabled (no-changelog) #7827

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 27, 2023

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 27, 2023
@netroy netroy force-pushed the upgrade-node-20 branch 3 times, most recently from d2ea28d to b00269c Compare November 28, 2023 15:51
@netroy netroy changed the title ci: Upgrade nodejs 20 to the latest version (no-changelog) ci: Fix editor tests when coverage is enabled (no-changelog) Nov 28, 2023
cstuncsik
cstuncsik previously approved these changes Nov 28, 2023
Copy link

cypress bot commented Nov 28, 2023

Passing run #3086 ↗︎

0 288 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 0e1fd50363
Status: Passed Duration: 05:52 💡
Started: Nov 28, 2023 4:56 PM Ended: Nov 28, 2023 5:02 PM

Review all test suite changes for PR #7827 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 2f8cb41 into master Nov 28, 2023
19 checks passed
@netroy netroy deleted the upgrade-node-20 branch November 28, 2023 17:04
MiloradFilipovic added a commit that referenced this pull request Nov 29, 2023
* master:
  fix(editor): Add telemetry to workflow history (#7811)
  fix(editor): Fix mouse position in workflow previews (#7853)
  fix(editor): Fix icon for unknown node type (#7842)
  ci: Fix editor tests when coverage is enabled (no-changelog) (#7827)
  fix(editor): Suppress dev server websocket messages in workflow view (#7808)
  feat(core): Update LLM applications building support (no-changelog) (#7710)
  fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) (#7851)
  fix(editor): Remove ability for users to select admin role in the UI (no-changelog) (#7850)
  feat(core): Set up endpoint for all existing roles with license flag (#7834)
  fix(editor): Fix credential icon for old node type version (#7843)
  feat: Add initial scope checks via decorators (#7737)
  refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) (#7838)
  fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833)
  refactor(core): Reorganize error hierarchy in `cli` package (no-changelog) (#7839)
  fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working (#7832)
  fix(Google Sheets Node): Read operation execute for each item (#7800)
  fix(core): Node version in the user added node to workflow canvas event (no-changelog) (#7814)
@janober
Copy link
Member

janober commented Dec 1, 2023

Got released with n8n@1.19.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants