Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working #7832

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Nov 27, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/issue-with-some-google-calendars/33411

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 27, 2023
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Nov 28, 2023

Passing run #3056 ↗︎

0 288 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 3eba9dcfcd
Status: Passed Duration: 05:45 💡
Started: Nov 28, 2023 7:22 AM Ended: Nov 28, 2023 7:28 AM

Review all test suite changes for PR #7832 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 38f24a6 into master Nov 28, 2023
19 checks passed
@Joffcom Joffcom deleted the forum/33411 branch November 28, 2023 09:11
rishikeshjoshi pushed a commit to rishikeshjoshi/n8n that referenced this pull request Nov 28, 2023
… holiday calendars from working (n8n-io#7832)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
MiloradFilipovic added a commit that referenced this pull request Nov 29, 2023
* master:
  fix(editor): Add telemetry to workflow history (#7811)
  fix(editor): Fix mouse position in workflow previews (#7853)
  fix(editor): Fix icon for unknown node type (#7842)
  ci: Fix editor tests when coverage is enabled (no-changelog) (#7827)
  fix(editor): Suppress dev server websocket messages in workflow view (#7808)
  feat(core): Update LLM applications building support (no-changelog) (#7710)
  fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) (#7851)
  fix(editor): Remove ability for users to select admin role in the UI (no-changelog) (#7850)
  feat(core): Set up endpoint for all existing roles with license flag (#7834)
  fix(editor): Fix credential icon for old node type version (#7843)
  feat: Add initial scope checks via decorators (#7737)
  refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) (#7838)
  fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833)
  refactor(core): Reorganize error hierarchy in `cli` package (no-changelog) (#7839)
  fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working (#7832)
  fix(Google Sheets Node): Read operation execute for each item (#7800)
  fix(core): Node version in the user added node to workflow canvas event (no-changelog) (#7814)
netroy pushed a commit that referenced this pull request Nov 29, 2023
… holiday calendars from working (#7832)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
@janober
Copy link
Member

janober commented Nov 30, 2023

Got released with n8n@1.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants