fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows #8334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array de-structuring combined with
.push(
on an array of 120k items is always going push the stack beyond it's max size. This is why why we should avoid this pattern whenever possible.We've already had to fix this exact same issue for the Google Sheets Node in #7384
Related tickets and issues
Fixes #8333
Review / Merge checklist