Skip to content

Commit

Permalink
fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error…
Browse files Browse the repository at this point in the history
… on too many rows (#8334)
  • Loading branch information
netroy committed Jan 15, 2024
1 parent c921665 commit bb2be8d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ export class MicrosoftSql implements INodeType {
const pool = configurePool(credentials);
await pool.connect();

const returnItems: INodeExecutionData[] = [];
let responseData: IDataObject | IDataObject[] = [];

const items = this.getInputData();
Expand Down Expand Up @@ -327,12 +326,11 @@ export class MicrosoftSql implements INodeType {

const itemData = generatePairedItemData(items.length);

const executionData = this.helpers.constructExecutionMetaData(
const returnItems = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData),
{ itemData },
);

returnItems.push(...executionData);
return [returnItems];
}
}

0 comments on commit bb2be8d

Please sign in to comment.