-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Show pin button on binary output but disable it with tooltip #8388
Merged
cstuncsik
merged 7 commits into
master
from
pay-410-when-ndv-has-binary-data-pin-edit-actions-are-hidden
Jan 26, 2024
Merged
fix(editor): Show pin button on binary output but disable it with tooltip #8388
cstuncsik
merged 7 commits into
master
from
pay-410-when-ndv-has-binary-data-pin-edit-actions-are-hidden
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Jan 18, 2024
…s-binary-data-pin-edit-actions-are-hidden
cstuncsik
changed the title
fix(editor): Show pin button on binary output but diable it with tooltip
fix(editor): Show pin button on binary output but disable it with tooltip
Jan 23, 2024
mutdmour
approved these changes
Jan 25, 2024
|
2 flaky tests on run #3913 ↗︎
Details:
5-ndv.cy.ts • 1 flaky test
17-sharing.cy.ts • 1 flaky test
Review all test suite changes for PR #8388 ↗︎ |
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-410-when-ndv-has-binary-data-pin-edit-actions-are-hidden
branch
January 26, 2024 05:54
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 26, 2024
* master: fix(editor): Fix workflows filter resetting (#8411) fix(editor): Show pin button on binary output but disable it with tooltip (#8388) fix(Merge Node): Passing on no items to "Input 2" results in wrong output items (#8438) ci: Enforce `noUnusedLocals` on all backend and nodes packages (no-changelog) (#8428) ci: Move docs check notification to #alerts-build (no-changelog) (#8435) 🚀 Release 1.26.0 (#8427)
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When NDV has binary data, Pin + Edit actions are hidden
Description
When NDV has binary data, Pin + Edit actions are hidden
Expected
Pin button shows up disabled with a tooltip on hover
Steps or workflow to reproduce (with screenshots/recordings)
n8n version: 0.224.1