ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog)
#8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
reviewed
Jan 25, 2024
netroy
force-pushed
the
fail-lint-on-unused-private-properties
branch
from
42448d5
to
a1daaee
Compare
ivov
reviewed
Jan 25, 2024
Comment on lines
-428
to
-433
| { | ||
| argsIgnorePattern: '^_', | ||
| destructuredArrayIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| ignoreRestSiblings: true, | ||
| }, |
There was a problem hiding this comment.
My only doubt was whether we could exempt unused params with underscore, but it looks like the TS setting supports this out of the box 👍🏻
ivov
approved these changes
Jan 25, 2024
3 flaky tests on run #3903 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
28-debug.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8428 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 26, 2024
* master: fix(editor): Fix workflows filter resetting (#8411) fix(editor): Show pin button on binary output but disable it with tooltip (#8388) fix(Merge Node): Passing on no items to "Input 2" results in wrong output items (#8438) ci: Enforce `noUnusedLocals` on all backend and nodes packages (no-changelog) (#8428) ci: Move docs check notification to #alerts-build (no-changelog) (#8435) 🚀 Release 1.26.0 (#8427)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully makes backend code a tiny bit cleaner.
Review / Merge checklist