-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enforce noUnusedLocals
on all backend and nodes packages (no-changelog)
#8428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going this route, we could add noUnusedParameters
and so remove @typescript-eslint/no-unused-vars
.
42448d5
to
a1daaee
Compare
{ | ||
argsIgnorePattern: '^_', | ||
destructuredArrayIgnorePattern: '^_', | ||
varsIgnorePattern: '^_', | ||
ignoreRestSiblings: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only doubt was whether we could exempt unused params with underscore, but it looks like the TS setting supports this out of the box 👍🏻
3 flaky tests on run #3903 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
17-sharing.cy.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
28-debug.cy.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Debug > should be able to debug executions |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #8428 ↗︎
✅ All Cypress E2E specs passed |
* master: fix(editor): Fix workflows filter resetting (#8411) fix(editor): Show pin button on binary output but disable it with tooltip (#8388) fix(Merge Node): Passing on no items to "Input 2" results in wrong output items (#8438) ci: Enforce `noUnusedLocals` on all backend and nodes packages (no-changelog) (#8428) ci: Move docs check notification to #alerts-build (no-changelog) (#8435) 🚀 Release 1.26.0 (#8427)
Got released with |
This hopefully makes backend code a tiny bit cleaner.
Review / Merge checklist