refactor(core): Remove roleId indirection (no-changelog) #8413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #3868 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8413 ↗︎
n8n-assistant
bot
added
core
2 tasks
netroy
changed the title
valya
requested changes
Jan 23, 2024
netroy
force-pushed
the
remove-sharing-role-mapping
branch
from
e953604
to
15eb8cc
Compare
valya
approved these changes
Jan 24, 2024
|
✅ All Cypress E2E specs passed |
|
let's merge this after the release to give us more time to catch any potential bugs this might cause. |
krynble
approved these changes
Jan 24, 2024
|
✅ All Cypress E2E specs passed |
2 tasks
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all of the old role-mapping code, so that we can start building a better RBAC from ground-up.
This includes removal of
globalRoleIdfrom theusertable, as well as theroleIdfromshared_*tables.The
roletable isn't dropped in this PR, and should we kept around until we have a clear plan for RBAC, as we might still need that table.Review / Merge checklist