Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: Remove legacy --file flag for execute CLI command #9054

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Apr 4, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 4, 2024
@ivov ivov changed the title refactor(core)!: Remove legacy --file flag for execute CLI command` refactor(core)!: Remove legacy --file flag for execute CLI command Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Apr 5, 2024

1 flaky test on run #4601 ↗︎

0 353 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project: n8n Commit: 3703bfe3ef
Status: Passed Duration: 04:11 💡
Started: Apr 5, 2024 1:38 PM Ended: Apr 5, 2024 1:42 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video

Review all test suite changes for PR #9054 ↗︎

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit 4052b6c into master Apr 5, 2024
29 checks passed
@ivov ivov deleted the pay-835-bug-cli-execute-workflow-from-file-fails branch April 5, 2024 12:28
MiloradFilipovic added a commit that referenced this pull request Apr 5, 2024
* master:
  refactor(core)!: Remove legacy `--file` flag for `execute` CLI command (#9054)
  fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062)
  ci: Delete some duplicate code in cli tests (no-changelog) (#9049)
  refactor(core, editor): Remove legacy `nodesAccess` (no-changelog) (#9016)
  refactor(editor): Remove legacy audit logs view (no-changelog) (#9053)
  refactor(editor): Do not make rest api calls for disabled features (no-changelog) (#9046)
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with n8n@1.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants