Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Delete some duplicate code in cli tests (no-changelog) #9049

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 3, 2024

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 3, 2024
packages/cli/test/shared/mocking.ts Outdated Show resolved Hide resolved
packages/cli/test/integration/shared/db/users.ts Outdated Show resolved Hide resolved
ivov
ivov previously approved these changes Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Apr 5, 2024

Passing run #4591 ↗︎

0 1 0 0 Flakiness 0

Details:

🌳 fix-flaky-ndv-test 🖥️ browsers:node18.12.0-chrome107 🤖 milorad 🗃️ e2e/5-nd...
Project: n8n Commit: ad3315a215
Status: Passed Duration: 00:15 💡
Started: Apr 5, 2024 12:13 PM Ended: Apr 5, 2024 12:14 PM

Review all test suite changes for PR #9049 ↗︎

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit ff77ef4 into master Apr 5, 2024
28 checks passed
@netroy netroy deleted the random-cleanup-2 branch April 5, 2024 11:47
MiloradFilipovic added a commit that referenced this pull request Apr 5, 2024
* master:
  refactor(core)!: Remove legacy `--file` flag for `execute` CLI command (#9054)
  fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062)
  ci: Delete some duplicate code in cli tests (no-changelog) (#9049)
  refactor(core, editor): Remove legacy `nodesAccess` (no-changelog) (#9016)
  refactor(editor): Remove legacy audit logs view (no-changelog) (#9053)
  refactor(editor): Do not make rest api calls for disabled features (no-changelog) (#9046)
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with n8n@1.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants