refactor(editor): Do not make rest api calls for disabled features (no-changelog) #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
tomi
reviewed
Apr 4, 2024
3 flaky tests on run #4578 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9046 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 5, 2024
* master: refactor(core)!: Remove legacy `--file` flag for `execute` CLI command (#9054) fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062) ci: Delete some duplicate code in cli tests (no-changelog) (#9049) refactor(core, editor): Remove legacy `nodesAccess` (no-changelog) (#9016) refactor(editor): Remove legacy audit logs view (no-changelog) (#9053) refactor(editor): Do not make rest api calls for disabled features (no-changelog) (#9046)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes calls to the following endpoints when the respective feature is disabled:
GET /rest/loginin demo mode (preview instance). After this is merged, we can remove the hooks hack on the preview instance.GET /rest/variableswhen variables are not availableGET /rest/external-secrets/secrets,GET /rest/external-secrets/providers, andGET /rest/source-control/preferenceswhen source-control/environments is disabledReview / Merge checklist