Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Cleanup Workflow.ts a bit, and add some unit tests (no-changelog) #9858

Closed
wants to merge 1 commit into from
Closed

refactor(core): Cleanup Workflow.ts a bit, and add some unit tests (no-changelog) #9858

wants to merge 1 commit into from

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 25, 2024

Summary

This PR is a tiny step towards making Workflow.ts maintainable, and with 100% test coverage.

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@netroy netroy changed the title refactor(core): Cleanup Workflow.ts and add some tests (no-changelog) refactor(core): Cleanup Workflow.ts a bit, and add some unit tests (no-changelog) Jun 25, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 25, 2024
despairblue
despairblue reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the tests and refactor in 2 different PRs or 2 different commits?
Or if the tests depend on the refactor make one commit per refactor and test, so it's apparent what changes in workflow.ts were driven by which unit test?

@netroy
Copy link
Member Author

netroy commented Jun 26, 2024

Could we add the tests and refactor in 2 different PRs or 2 different commits?

I'll move the tests out in a separate PR then. We can rebase this PR after that.

@netroy netroy mentioned this pull request Jun 26, 2024
Merged
2 tasks
@netroy
Copy link
Member Author

netroy commented Jun 27, 2024

I'm looking into the possibility of making Workflow updatable and reactive. Closing this PR for now. If I continue down this trajectory, will reopen this PR.

@netroy netroy closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despairblue despairblue despairblue left review comments

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@netroy @despairblue