refactor(core): Add more unit tests for Workflow.ts (no-changelog)
#9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
…abled nodes 1. ignore a node that would otherwise make the function return true 2. disable a node that would make the function return true if it wasn't disabled
despairblue
reviewed
Jun 27, 2024
| nodeTypes, | ||
| }); | ||
|
|
||
| const issues = workflow.checkReadyForExecution({ startNode: disabledNode.name }); |
There was a problem hiding this comment.
You're given a startNode in multiple tests here, but no destinationNode.
All these tests would also work if we didn't pass the start node. So I assume it's to be able to test the branch that calls getChildNodes.
Would it make sense to change one of these tests to pass destinationNode so that we also cover getParentNodes?
There was a problem hiding this comment.
I think we should add a separate group of tests for destinationNode.
But, I can do that in the next PR adding tests for Workflow.
despairblue
approved these changes
Jun 27, 2024
4 flaky tests on run #5690 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
12-canvas.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch |
Test Replay
Screenshots
Video
|
|
2-credentials.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Credentials > should show multiple credential types in the same dropdown |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9868 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted out of #9858
Review / Merge checklist