Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(editor): Rename $emits to emits where we use defineEmits (no-changelog) #9959

Merged
merged 3 commits into from
Jul 6, 2024
Merged

refactor(editor): Rename $emits to emits where we use defineEmits (no-changelog) #9959

merged 3 commits into from
Jul 6, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jul 6, 2024 •
edited
Loading

Summary

Follow PR to #9934

  1. Rename remaining instances of $emit to emit.
  2. Rename instances of $attrs to attrs.
  3. Add linting rule to force variable names when using defineEmit , defineProps, defineSlots, useSlots and useAttrs

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Rename $emits to emits where we use defineEmits reactor(editor): Rename $emits to emits where we use defineEmits Jul 6, 2024
@RicardoE105 RicardoE105 changed the title reactor(editor): Rename $emits to emits where we use defineEmits refactor(editor): Rename $emits to emits where we use defineEmits Jul 6, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 6, 2024
@RicardoE105 RicardoE105 changed the title refactor(editor): Rename $emits to emits where we use defineEmits refactor(editor): Rename $emits to emits where we use defineEmits (no-changelog) Jul 6, 2024
@cypress Cypress
Copy link

cypress bot commented Jul 6, 2024 •
edited
Loading

4 flaky tests on run #5816 ↗︎

0 399 0 0 Flakiness 4

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: 1ae64ec4fb
Status: Passed Duration: 05:35 💡
Started: Jul 8, 2024 3:11 AM Ended: Jul 8, 2024 3:16 AM
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  5-ndv.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9959 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 1ae64ec into master Jul 6, 2024
29 checks passed
@RicardoE105 RicardoE105 deleted the rename-$emits branch July 6, 2024 17:54
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
@RicardoE105 @jeanpaul
refactor(editor): Rename $emits to emits where we use `defineEmit…
e7769de 
…s` (no-changelog) (#9959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

@alexgrozav alexgrozav Awaiting requested review from alexgrozav

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @netroy