Days::in should use in_mask; tests coverage #1180

nabeelio · May 19, 2021 · 20b7965 · 20b7965
1 parent dff4273
commit 20b7965
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/Models/Enums/Days.php b/app/Models/Enums/Days.php
@@ -77,7 +77,7 @@ public static function getDaysMask(array $days)
      */
     public static function in($mask, $day): bool
     {
-        return ($mask & $day) === $day;
+        return in_mask($mask, $day);
     }
 
     /**

diff --git a/tests/FlightTest.php b/tests/FlightTest.php
@@ -279,6 +279,7 @@ public function testFindDaysOfWeek(): void
      */
     public function testDayOfWeekActive(): void
     {
+        /** @var User user */
         $this->user = factory(User::class)->create();
 
         // Set it to Monday or Tuesday, depending on what today is
@@ -289,6 +290,8 @@ public function testDayOfWeekActive(): void
         }
 
         factory(Flight::class, 5)->create();
+
+        /** @var Flight $flight */
         $flight = factory(Flight::class)->create([
             'days' => $days,
         ]);
@@ -323,6 +326,12 @@ public function testDayOfWeekTests(): void
         $this->assertTrue(Days::in($mask, Days::$isoDayMap[5]));
         $this->assertTrue(Days::in($mask, Days::$isoDayMap[6]));
         $this->assertTrue(Days::in($mask, Days::$isoDayMap[7]));
+
+        $mask = [];
+        $this->assertFalse(Days::in($mask, Days::$isoDayMap[1]));
+
+        $mask = 0;
+        $this->assertFalse(Days::in($mask, Days::$isoDayMap[1]));
     }
 
     public function testStartEndDate(): void