-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
laravel-helpers is outdated and causes errors on .../admin/flights/create #1180
Comments
As far as I know, phpvms does not support php8 (yet). Though the developer was working on it, but we are still limited to php 7.3 and 7.4 series but not 8. This may be the root cause of the error you are facing. |
Yep, I'm still waiting on a couple of upstream libraries to include PHP 8 support. Though, I will look again and probably get rid of those libraries if I can for PHP 8 support. |
Please try the latest dev. I removed the library that was holding back PHP 8 compatibility |
Yes the installation with composer is working now. But there are still errors when trying to create a new flight at https://....net/admin/flights/create |
Can you supply the logs/those errors? |
Closes nabeelio#1180 and nabeelio#1156. But now the script isn't beeing loaded
Well I think I fixed that issue. But now the script isn't beeing loaded, because the script is made for the edit fields.blade |
What you did is not fixing the problem, you just removed a necessary
dynamic array, put a fixed value (zero) instead ...
Of course that will broke the schedule days logic :(
--
B. Fatih KOZ
Sent from mobile device / Mobil cihaz ile gonderildi.
|
No it seems that the days are saved in a mask. The enum sets monday to a 1 and sunday is representing a 64. The days acutally arent saved in an array, they are saved in an int. The in_mask operation makes a bitwise comparison. So 127 represents all days beeing selected. In PHP 7 an empty array was representing an 0 and a bitwise operation was successful. Since in PHP8 they change that its important to set it to 0 or null. Soo The sripts aren loading because only the edit.blade.php imports them. The create.blade.pho in /resources/views/admin/flights doesnt. Edit: Thats why this function in_mask is beeing used for the selection |
Yes, you are right, my mistake sorry ... I just thought that you are returning 0 for all, in fact you were returning 0 only for the create view :) |
It's happening only under PHP 8? I need to install PHP 8 and see if I can duplicate it |
Pushed a couple of fixes, see if that helps |
Yes. For me this happend in PHP8 before we had no issues with that or maybe an extension had overwritten that function 🤷♂️ |
The error has been cleaned. Thank you @nabeelio But there is still the issue with no scripts beeing loaded. They are only loaded in |
I don't know what "no scripts being loaded" means. Is there an error? Example? Screenshots? |
Is this on the default skin? And what's in the error console? |
Jep. Its the default skin! Well there is no error. In Edit.blade.php at line 31 the scripts are included in Create.blade.php they aren't Edit: fixed the links |
I think this is what causes this "error" but this is just a shot. Idk |
I see what you mean now. Thanks for pointing that out. Pushing a new update to dev. |
Thanks. Jep I didn't know how to explain it in a better way than showing the lines :| Thank you |
Describe the bug
Old version of sebastiaanluca/laravel-helpers causes errors. Can't run composer install and https://royalevest.de/admin/flights/create returns an error
Version
latest dev
To Reproduce
Steps to reproduce the behavior:
Error on composer install:
- sebastiaanluca/laravel-helpers is locked to version 6.0.0 and an update of this package was not requested.
- sebastiaanluca/laravel-helpers 6.0.0 requires php ^7.3 -> your php version (8.0.5) does not satisfy that requirement.
Other error:
Unsupported operand types: array & int
`if (!function_exists('in_mask')) {
}`
The text was updated successfully, but these errors were encountered: