laravel-helpers is outdated and causes errors on .../admin/flights/create

[ollimaz]

Describe the bug
Old version of sebastiaanluca/laravel-helpers causes errors. Can't run composer install and https://royalevest.de/admin/flights/create returns an error

Version
latest dev

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Admin'
2. Click on 'Flights'
3. Click on 'Add Flight'

Error on composer install:
- sebastiaanluca/laravel-helpers is locked to version 6.0.0 and an update of this package was not requested.
- sebastiaanluca/laravel-helpers 6.0.0 requires php ^7.3 -> your php version (8.0.5) does not satisfy that requirement.
Other error:
Unsupported operand types: array & int

`if (!function_exists('in_mask')) {

/**

 * Return true/false if a value exists in a mask

 *

 * @param $mask

 * @param $value

 *

 * @return bool

 */

function in_mask($mask, $value)

{

    return ($mask & $value) === $value;

}

}`

[FatihKoz]

your php version (8.0.5) does not satisfy that requirement.

As far as I know, phpvms does not support php8 (yet). Though the developer was working on it, but we are still limited to php 7.3 and 7.4 series but not 8.

This may be the root cause of the error you are facing.

[nabeelio]

Yep, I'm still waiting on a couple of upstream libraries to include PHP 8 support. Though, I will look again and probably get rid of those libraries if I can for PHP 8 support.

[nabeelio]

Please try the latest dev. I removed the library that was holding back PHP 8 compatibility

[ollimaz]

Yes the installation with composer is working now. But there are still errors when trying to create a new flight at https://....net/admin/flights/create

[nabeelio]

Can you supply the logs/those errors?

[FatihKoz]

#1156 has some more info about the issue, even a flare share link (caused by php8 / operand type)

@oudrun was using php8 when he faced that error, recently switched back to 7.4.xx series I think.

[ollimaz]

Well I think I fixed that issue. But now the script isn't beeing loaded, because the script is made for the edit fields.blade

[FatihKoz]

What you did is not fixing the problem, you just removed a necessary dynamic array, put a fixed value (zero) instead ... Of course that will broke the schedule days logic :( -- B. Fatih KOZ Sent from mobile device / Mobil cihaz ile gonderildi.

[ollimaz]

No it seems that the days are saved in a mask. The enum sets monday to a 1 and sunday is representing a 64. The days acutally arent saved in an array, they are saved in an int. The in_mask operation makes a bitwise comparison. So 127 represents all days beeing selected. In PHP 7 an empty array was representing an 0 and a bitwise operation was successful. Since in PHP8 they change that its important to set it to 0 or null.
1 = 1 monday
2 = 10 Tuesday
4 = 100 Wednesday
8 = 1000 Thursday
16 = 10000 Friday
...

Soo
1000101
Represents Monday, Wednesday and Sunday beeing selected.

The sripts aren loading because only the edit.blade.php imports them. The create.blade.pho in /resources/views/admin/flights doesnt.

Edit: Thats why this function in_mask is beeing used for the selection

[FatihKoz]

Yes, you are right, my mistake sorry ... I just thought that you are returning 0 for all, in fact you were returning 0 only for the create view :)

[nabeelio]

It's happening only under PHP 8? I need to install PHP 8 and see if I can duplicate it

[nabeelio]

Pushed a couple of fixes, see if that helps

[ollimaz]

Yes. For me this happend in PHP8 before we had no issues with that or maybe an extension had overwritten that function 🤷‍♂️

[ollimaz]

The error has been cleaned. Thank you @nabeelio

But there is still the issue with no scripts beeing loaded. They are only loaded in
phpvms/resources/views/admin/flights/edit.blade.php and not in
phpvms/resources/views/admin/flights/create.blade.php

[nabeelio]

I don't know what "no scripts being loaded" means. Is there an error? Example? Screenshots?

[ollimaz]

This is how it looks. No date picker and no fancy days selector

This is how it looks when editing and how it should look like:

[nabeelio]

Is this on the default skin? And what's in the error console?

[ollimaz]

Jep. Its the default skin! Well there is no error. In Edit.blade.php at line 31 the scripts are included in Create.blade.php they aren't

Edit: fixed the links

[ollimaz]

I think this is what causes this "error" but this is just a shot. Idk

[nabeelio]

I see what you mean now. Thanks for pointing that out. Pushing a new update to dev.

[ollimaz]

Thanks. Jep I didn't know how to explain it in a better way than showing the lines :| Thank you