Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #12

Open
kaesrel opened this issue Nov 22, 2021 · 1 comment
Open

Comments #12

kaesrel opened this issue Nov 22, 2021 · 1 comment

Comments

@kaesrel
Copy link

kaesrel commented Nov 22, 2021

Iteration 2

  • The goals are not written in complete sentences.
  • All tasks are completed.
  • Included iteration 2 branch, and merged to main/master.
  • The methods in the questions class in models.py are sufficiently complete. The lines 51-53 in can_vote() method can be refactored into just a single return statement.
  • Externalized configurations are okay. However the DEBUG config() does not contain cast=bool. Also, it is recommended to have default config values.
  • Navigation back to polls index page from detail page and result page is complete.

Continuous Integration

  • CI build and Codecov badge are complete.

Iteration 3

  • The goals are not written in complete sentences.
  • Have only a few tasks, though all of them are complete.
  • No users fixture file. Polls fixture file data cannot be loaded. The votes field must be removed to make loading possible.
  • No sample users provided in the README.md
  • No logout button/hyperlink
  • "1 vote per poll per user" is implemented correctly.
  • "Only authenticated user can vote" works correctly.

Additional Comments

I will give you a chance to fix the polls.json fixture. Contact me in discord once you have fixed it, so that I can regrade it.

@kaesrel
Copy link
Author

kaesrel commented Dec 2, 2021

Seems like you have fixed the fixture files. It now works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant