You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included iteration 2 branch, and merged to main/master.
The methods in the questions class in models.py are sufficiently complete. The lines 51-53 in can_vote() method can be refactored into just a single return statement.
Externalized configurations are okay. However the DEBUG config() does not contain cast=bool. Also, it is recommended to have default config values.
Navigation back to polls index page from detail page and result page is complete.
Continuous Integration
CI build and Codecov badge are complete.
Iteration 3
The goals are not written in complete sentences.
Have only a few tasks, though all of them are complete.
No users fixture file. Polls fixture file data cannot be loaded. The votes field must be removed to make loading possible.
No sample users provided in the README.md
No logout button/hyperlink
"1 vote per poll per user" is implemented correctly.
"Only authenticated user can vote" works correctly.
Additional Comments
I will give you a chance to fix the polls.json fixture. Contact me in discord once you have fixed it, so that I can regrade it.
The text was updated successfully, but these errors were encountered:
Iteration 2
iteration 2
branch, and merged tomain
/master
.models.py
are sufficiently complete. The lines 51-53 incan_vote()
method can be refactored into just a single return statement.config()
does not containcast=bool
. Also, it is recommended to have default config values.Continuous Integration
Iteration 3
votes
field must be removed to make loading possible.README.md
Additional Comments
I will give you a chance to fix the polls.json fixture. Contact me in discord once you have fixed it, so that I can regrade it.
The text was updated successfully, but these errors were encountered: