Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing associations when emitting events #122

Closed
naddison36 opened this issue Dec 12, 2022 · 1 comment
Closed

Missing associations when emitting events #122

naddison36 opened this issue Dec 12, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@naddison36
Copy link
Owner

naddison36 commented Dec 12, 2022

An example is in this contract 0xC6845a5C768BF8D7681249f8927877Efda425baf on mainnet.
The associations from the StableAndVariableTokensHelper and ATokensAndRatesHelper contracts to the StringLib library are missing.

The StableAndVariableTokensHelper.initDeployment function has the following expression.

emit deployedContracts(
  address(
    new StableDebtToken(
      pool,
      tokens[i],
      StringLib.concat('Aave stable debt bearing ', symbols[i]),
      StringLib.concat('stableDebt', symbols[i]),
      incentivesController
    )
  ),
  address(
    new VariableDebtToken(
      pool,
      tokens[i],
      StringLib.concat('Aave variable debt bearing ', symbols[i]),
      StringLib.concat('variableDebt', symbols[i]),
      incentivesController
    )
  )
);

The ATokensAndRatesHelper.initDeployment function has the following expression.

emit deployedContracts(
  address(
    new AToken(
      LendingPool(pool),
      assets[i],
      treasuryAddress,
      StringLib.concat('Aave interest bearing ', symbols[i]),
      StringLib.concat('a', symbols[i]),
      incentivesController
    )
  ),
  address(
    new DefaultReserveInterestRateStrategy(
      LendingPoolAddressesProvider(addressesProvider),
      rates[i][0],
      rates[i][1],
      rates[i][2],
      rates[i][3],
      rates[i][4],
      rates[i][5]
    )
  )
);
@naddison36 naddison36 added the bug Something isn't working label Dec 12, 2022
@naddison36 naddison36 self-assigned this Dec 12, 2022
@naddison36
Copy link
Owner Author

Fixed with v2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant