Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Deprecate implicit thread-local currentPage, add implicit Page arguments where lacking #52

Closed
nafg opened this issue May 18, 2012 · 1 comment
Assignees
Labels
Milestone

Comments

@nafg
Copy link
Owner

nafg commented May 18, 2012

Convenient sometimes, but then surprisingly things don't work, when updates come from outside that page's thread (either server push, or by a user interaction on another page).
More importantly, a lot of methods in reactive call methods that take an implicit Page but don't themselves take one. By (at least temporarily) deprecating currentPage, the compiler will reveal the trail.

Perhaps currentPage doesn't need to be removed, and we can just leave the @deprecated annotation in order to generate compiler warning messages.

Does anyone think that this should bump the version number?

@ghost ghost assigned nafg May 18, 2012
@nafg
Copy link
Owner Author

nafg commented Apr 23, 2013

Fixed in 7b74048

@nafg nafg closed this as completed Apr 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant