Prevent oauth/token hang using access route internal #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Siap, mas @satyakresna bisa bantu perbaiki style-ci failsnya? |
|
Halo mas @nafiesl , sip sudah saya perbaiki. Mohon di merge-request ya. |
|
makasih mas @satyakresna 🙏 |
|
Sama" mas @nafiesl. 🙏
…On Tue, Aug 27, 2019, 19:44 Nafies Luthfi ***@***.***> wrote:
makasih mas @satyakresna <https://github.com/satyakresna> 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26?email_source=notifications&email_token=ACUVYMXCANYJUF4AS4LDXQLQGUHTBA5CNFSM4IPKQHRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HOLQY#issuecomment-525264323>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACUVYMT664IVHH4W3QNFNGLQGUHTBANCNFSM4IPKQHRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mengapa?
Jika user menggunakan perintah
php artisan servedan tidak menggunakan Valet atau homestead untuk membuat dummy domain (embel".test) maka yang akan terjadi adalah saat menggunakan Guzzle maupun Curl adalah request bolak balik dan ujung"nya hang.Solusi yang bisa ditawarkan adalah mengirim data tersebut lewat route internal seperti yang disebutkan di forum SO: https://stackoverflow.com/questions/51000573/laravel-5-6-pass-oauth-token-hanging.
Saya barusan sudah mencoba untuk dummy domain maupun dengan localhost.