Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

[BUG] Inconsistent fetch_* function behaviour #323

Closed
Kigstn opened this issue Feb 22, 2022 · 1 comment · Fixed by #326
Closed

[BUG] Inconsistent fetch_* function behaviour #323

Kigstn opened this issue Feb 22, 2022 · 1 comment · Fixed by #326
Assignees
Labels
Improvement Something that is already implemented but can be done better

Comments

@Kigstn
Copy link
Member

Kigstn commented Feb 22, 2022

Describe the bug
Not all .fetch_* instances return None optionally. Some raise not found errors.

Someone needs to go through all methods and make sure the NotFound exception is caught and None is returned everywhere. Currently it's 50/50

This is needed everywhere

        try:
            return await self.cache.fetch_member(guild_id, user_id)
        except NotFound:
            return None
@Kigstn Kigstn changed the title [BUG] Your Title Here [BUG] Inconsistent fetch_* function behaviour Feb 22, 2022
@Kigstn Kigstn added the Improvement Something that is already implemented but can be done better label Feb 22, 2022
@benwoo1110 benwoo1110 self-assigned this Feb 24, 2022
@benwoo1110
Copy link
Contributor

benwoo1110 commented Feb 24, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Something that is already implemented but can be done better
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants