Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(on filtering refactor, not released versions) searching is broken, task addressing is broken #56

Closed
4 tasks
naggie opened this issue Oct 7, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@naggie
Copy link
Owner

naggie commented Oct 7, 2020

In master, since #53 searching by keyword is broken.

  • fix task addressing, eg dstask 23
  • fix task search eg task banana
  • unit test for task addressing
  • unit test for task search
@naggie naggie added the bug Something isn't working label Oct 7, 2020
@dontlaugh
Copy link
Contributor

I will take a look at this tonight

@naggie
Copy link
Owner Author

naggie commented Oct 7, 2020

ok, thanks 👍

@naggie naggie changed the title searching is broken, task addressing is broken (on master, not released versions) searching is broken, task addressing is broken Oct 7, 2020
@dontlaugh
Copy link
Contributor

For indexing by ID, what is the desired behavior, exactly? Is it: if an ID is explicitly passed, the task will not be filtered from the result, regardless of context, tags, projects, etc. ?

@naggie
Copy link
Owner Author

naggie commented Oct 8, 2020

Specifying an ID allows tasks that are out of context to be manipulated: For example, sometimes I search outside the context with dstask -- project:dstask or something. Then I might want to close or view a task by ID.

If an ID is passed with filters such as tags or project, that should throw an error. I think that's the most clear way.

@naggie naggie changed the title (on master, not released versions) searching is broken, task addressing is broken (on filtering refactor, not released versions) searching is broken, task addressing is broken Oct 8, 2020
@naggie
Copy link
Owner Author

naggie commented Oct 8, 2020

Tracked as part of #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants