Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project uses spaces and tabs for indentation #268

Closed
berikv opened this issue Dec 16, 2021 · 2 comments
Closed

Project uses spaces and tabs for indentation #268

berikv opened this issue Dec 16, 2021 · 2 comments

Comments

@berikv
Copy link
Contributor

berikv commented Dec 16, 2021

I would suggest to use four spaces, but don't want to start a war over it :)
If tabs are the way to go, then lets convert all spaces to tabs in the remaining .c and .h files.

@NagyD NagyD closed this as completed in b4e0462 Dec 18, 2021
@NagyD
Copy link
Owner

NagyD commented Dec 19, 2021

I changed spaces to tabs where they were used for indentation (as opposed to aligning).
I didn't change the external libraries, though (src/opl3.c, src/opl3.h, src/stb_vorbis.c).

@berikv
Copy link
Contributor Author

berikv commented Dec 19, 2021

How would you feel about moving the external libraries to eg src/vendor/ and having a formatter / validator script in the project to fix the tabs / spaces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants