Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: add reducers and actions #2

Merged
merged 9 commits into from
Nov 8, 2022
Merged

Bookstore: add reducers and actions #2

merged 9 commits into from
Nov 8, 2022

Conversation

NahnahAJ
Copy link
Owner

@NahnahAJ NahnahAJ commented Nov 8, 2022

Project Requirements

  1. Add Redux Toolkit npm install react-redux @reduxjs/toolkit.

  2. Write your book's actions and reducer in /src/redux/books/books.js using the ducks pattern.

  • Define action types for adding and removing a book.
  • Set the initial state as an empty array of books.
  • Export Action Creators for your actions.
  • Write your reducer and export it as default.
  • Define state changes for the actions that you created.
  • In case of unknown action - return the current state.
  1. Write your categories actions and reducer in /src/redux/categories/categories.js using the ducks pattern.
  • Define an action type for checking the status.
  • Set the initial state as an empty array of categories.
  • Export Action Creators for your actions.
  • Write your reducer and export it as default.
  • For the check status action return a string "Under construction".
  • In case of unknown action - return the current state.
  1. Configure the Redux Store /src/redux/configureStore.js:
  • Importing the necessary methods from Redux Toolkit.
  • Combine both reducers into a root reducer using the configureStore function.

Copy link

@ShahierNashaat ShahierNashaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight 💯

  • Correct use of GitFlow ✔️
  • Descriptive commit messages ✔️
  • Professional looking pull request ✔️
  • Your readme looks professional ✔️
  • Your code is clean and well documented ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines 2 to 3
export const ADD_BOOK = 'book-store/redux/ADD_BOOK';
export const REMOVE_BOOK = 'book-store/redux/REMOVE_BOOK';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly notice that the value of each action type needs to follow the ducks pattern, so it will be something like: const ADD_BOOK = bookstore/books/ADD_BOOK and const REMOVE_BOOK = bookstore/books/REMOVE_BOOK, you should put books instead of redux.

@@ -0,0 +1,27 @@
// Define an action type for checking the status.
const CHECKSTATS = 'Under construction';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Also here the value of action type needs to follow the ducks pattern, so it will be something like: const CHECK_STATUS = bookstore/categories/CHECK_STATUS.

Copy link

@ShahierNashaat ShahierNashaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight 💯

  • Correct use of GitFlow ✔️
  • Descriptive commit messages ✔️
  • Professional looking pull request ✔️
  • Your readme looks professional ✔️
  • Your code is clean and well documented ✔️

Approved 👌 👌 👌

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NahnahAJ NahnahAJ merged commit a7e7d4f into develop Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants