Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookstore: connect to API #4

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Bookstore: connect to API #4

merged 5 commits into from
Nov 11, 2022

Conversation

NahnahAJ
Copy link
Owner

Project requirements

  • Refactor your code to use the Bookstore API to add and remove books.

  • Learnt how to use the Bookstore API documentation.

  • Use axios with createAsyncThunk for making API calls.

  • Fetch book list from Bookstore API on Books page load.

  • Add an Action Creator, that returns a function.

  • Fetch a list of books.

  • Dispatch another action (add an action type) that will pass the API response to the reducer and updates the state.

  • Refactor your add book and remove book features to persist your changes in the server.

  • Change your existing Action Creators, so they return functions.

  • Make changes by using API.

  • Dispatch an action (action type that existed before refactoring) that will update the state accordingly.

  • Add book and remove book should work in the same way after the refactor.

  • No styling is required.

Copy link

@codecaiine codecaiine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Good project implementation ✔️
  • App works as expected ✔️
  • No linters errors ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NahnahAJ NahnahAJ merged commit 4c8e25f into develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants